Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing fedimint-cli Upgrade Test #6385

Open
Tracked by #6349
bradleystachurski opened this issue Nov 18, 2024 · 1 comment
Open
Tracked by #6349

Failing fedimint-cli Upgrade Test #6385

bradleystachurski opened this issue Nov 18, 2024 · 1 comment
Assignees
@joschisan

Comments

@bradleystachurski
Copy link
Member

Upgrade tests are failing for fedimint-cli. To reproduce, you'll need to reference this branch, which reorgs this fix commit. This is necessary so git bisect can correctly identify the commit that introduced the next failure.

git fetch upstream cd9019415de0f3ec155098b0d971ac764369ac02
git checkout cd9019415de0f3ec155098b0d971ac764369ac02
TEST_KINDS=fedimint-cli just test-upgrades v0.4.0 current &> results.log

Expected error message

Error: Polling gateways registered failed after 107 retries (timeout: 60s)

Caused by:
    0: Internal client joining Federation
    1: command: /nix/store/wvxj5ikvc47mm7ab0yigjynps3xyciyj-fedimint-cli/bin/fedimint-cli --data-dir=/tmp/nix-shell.oTeLeg/devimint-1623638-737/clients/default-0 join-federation fed11qgqpw9thwvaz7te3xgmjuvpwxqhrzw33xgunzve0qqqjp58ttdqwuc6a9edkh5qkvl4k6duw9nxl5c5tmtruzuwt3ut4nu4wavtpvh
parallel: This job failed:
devimint upgrade-tests fedimint-cli --paths /nix/store/wvxj5ikvc47mm7ab0yigjynps3xyciyj-fedimint-cli/bin/fedimint-cli fedimint-cli
Some tests failed:
Seq Host    Starttime   JobRuntime  Send    Receive Exitval Signal  Command

1   :   1731891838.004      98.143  0   0   1   0   devimint upgrade-tests fedimint-cli --paths /nix/store/wvxj5ikvc47mm7ab0yigjynps3xyciyj-fedimint-cli/bin/fedimint-cli fedimint-cli

git bisect shows cd9019415de0f3ec155098b0d971ac764369ac02 introduced, which is 911e67287ae85ed30b754a3871aa3cedb6ceca98 on master.

git bisect start
git bisect good fb6310005f
git bisect bad ee2cb865304ad918273462ca4a979938bcb65675
...
cd9019415de0f3ec155098b0d971ac764369ac02 is the first bad commit
commit cd9019415de0f3ec155098b0d971ac764369ac02
Author: joschisan <joschisan@MacBook-Pro-von-Joscha.local>
Date:   Tue Nov 12 13:38:22 2024 +0200

    cleanup: sane network encoding for lnv2

@joschisan I've assigned your way since you have context
@bradleystachurski bradleystachurski mentioned this issue Nov 18, 2024
Open
13 tasks
@bradleystachurski
Copy link
Member Author

@joschisan Following up from our chat during the dev call. I ran upgrade tests after gating lnv2 on v0.5.0 and we still get the same failure. I captured the diff and logs in bradleystachurski@2fd930d

Please let me know if you had a different diff in mind when we talked on the call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joschisan joschisan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bradleystachurski @joschisan