Adding workaround for JDK > 8 invokedynamic tainting #690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@h3xstream - is there any update on this? |
h3xstream
approved these changes
Jul 26, 2023
| String signature = methodId.substring(methodId.indexOf("("), methodId.length()); | ||
| SignatureParser p = new SignatureParser(signature); | ||
| return p.getNumParameters(); | ||
| } |
There was a problem hiding this comment.
SignatureParser might not handle long and double parameters (which are double at runtime) but for makeConcatWithConstants it should be fine.
|
Might fix #701 |
|
It seems to help greatly for JDK11 bytecodes with the new option turned on. One thing that does not get fixed is taint propagation for
|
|
I have some changes building on this pull request to make |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
We @oxeye created a possible workaround for this previously discussed issue:
#575
We are not 100% sure that this is the optimal solution for this issue, so we would love to get your feedback on this so we can address your observations.
We also noticed that you have set the target version for fixing this issue for the next version (1.13 scheduled for December), is it still the due date?
Thanks