feat: add bones_camera_shake crate
#4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
68c8164
to
3f87256
Compare
bones_camera_shake cratebones_camera_shake crate
zicklag
reviewed
Dec 28, 2022
|
bors r+ |
|
👎 Rejected by PR status |
|
bors merge |
|
👎 Rejected by PR status |
|
bors help |
bones_camera_shake cratebones_camera_shake crate
|
Maybe you have to approve the PR? |
zicklag
approved these changes
Dec 28, 2022
|
bors merge |
|
👎 Rejected by PR status |
|
Very strange. I'll try changing the branch protection rules. bors merge |
|
👎 Rejected by PR status |
bones_camera_shake crate|
Looks like it might be a fluke or a bug. I'll try one more time before just merging it manually. https://forum.bors.tech/t/rejected-by-pr-status-despite-the-check-is-validated/645 bors merge |
|
👎 Rejected by PR status |
bones_camera_shake crate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on Discord, here is the camera shake functionality from Bomby. For the time being it uses
bevy_ecsand notbones_ecs.