-
-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dropdown] Search with remote content causes Firefox to hang #2971
Comments
The filtering does not work in that example as the "backend"-response is nothing else but a static JSON Value and wont be filtered at all. (This example just wants to show the preserveHTML setting difference) However, at the moment i cannot tell why Firefox 121.x+ freezes. I suspect a browser bug. Need to investigate |
Thanks @lubber-de for the clarification. Indeed, the freezing Firefox is the main problem. I just panicked a bit and thought the lack of filtering is a related issue, but you're right, that's not the case with the static JSON example. I did another investigation and it seems the number of records returned by the API matters.
|
I'm using Fomantic-UI css in conjunction with semantic-ui-react and experience the issue with static content (300 records) too. An example using the latest fomantic-ui/2.9.3/semantic.min.css can be found here: https://jsfiddle.net/7mk4s6u0/5/ - using Firefox, when starting to type "Computer" in the input field, the tab freezes. I tested downgrading to previous versions and found that it started working fine using fomantic-ui/2.9.1/semantic.min.css : https://jsfiddle.net/zowf18k6/ Hence, I assume the issue was introduced in 2.9.2. Downgrading to 2.9.1 fixed the issue for me. Hope this helps. |
@slachinger indeed, it helps ! Looks like it's a CSS issue with Firefox 121.x+, but i cannot figure what's happening here. In @supports selector(:has(.f)) {
*:has(> .ui.piled.segment) {
z-index: 0;
position: relative;
}
} And freezes are gone ! @lubber-de I suspect this to be the culprit, but why it's driving Firefox nuts is out of my knowledge ! |
Thanks for finding the reason @prudho ! What one can do right now:
What we can change in the core is either
- @supports selector(:has(.f)) {
+ @supports selector(:has(.f)) and (not(-moz-appearance: none)) { This could be removed again once it is fixed in firefox
What do you guys prefer? ( i vote for the first option to advance the |
I choose first option too. It's quick and just disable a buggy behavior without breaking anything else. |
mmh, i cannot get this to reprocuce locally or via a jsfiddle and not even by trying the docs locally. Firefox works just fine. @prudho Have you got a reproducable jsfiddle or how did you confirm removing the |
Here is my try to change the supports-selector as discussed above (i added a red background to find out if the additional rule will not affect firefox)...it still freezes although the selector is not even executed. So, even if we add my suggested change "dry" to the core, i suspect the issue still exists. |
And, even weird....last try: I removed the whole selector...firefox still freezes @prudho Please help if/where/how you confirmed it is fixed when removing the selector |
@slachinger @prudho https://jsfiddle.net/e70xjovw/1/ I would have expected firefox to freeze now.... but it doesnt (which would explain, why my previous teste also did not make any difference So the reason for the freeze must be somewhere else |
I got it. 💪🏼 It's a combination of 3 specific Using 2.9.2 and adding the 3 selectors in question will freeze firefox reproducable. adjusting the selector to ignore firefox will fix it in firefox However: keep in mind that the selectors in question do not even belong to the example code! There is no piled segment and no pointing dropdown so the selector will not even trigger. (and i also tested to make the I can confirm the change (of all 3 selectors) also fixes the docs page Will prepare a PR :) |
Fixed by #2973 |
I filed an issue for mozilla at webcompat/web-bugs#132131 |
mozilla confirmed the issue and takes care about that by https://bugzilla.mozilla.org/show_bug.cgi?id=1874066 |
I can confirm, the issue is fixed in latest firefox 123.a01 |
Firefox 123 was released today and fixed the issue. Please update your browser |
Bug Report
I have noticed strange behaviour in the Firefox browser version 121 and higher. The browser hangs when searching remote from API. Strangely enough, not all sources are causing the problem.
Steps to reproduce
It can be reproduced on the current docs
Expected result
I expect the list to be filtered.
Actual result
The page is actually frozen under Firefox and surprisingly this filtering doesn't work in other browsers.
On the other hand the other examples with remote content works fine, e.g.: https://fomantic-ui.com/modules/dropdown.html#match-search-query-on-server
Testcase
https://fomantic-ui.com/modules/dropdown.html#sanitized-version
Screenshot (if possible)
Version
Fomantic ver 2.9.3
Firefox 121
The text was updated successfully, but these errors were encountered: