Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing for saveOnStart PR #2564

Draft
wants to merge 41 commits into
base: main
Choose a base branch
from
Draft
Changes from 1 commit
Commits
Show all changes
41 commits
Select commit Hold shift + click to select a range
7a46bac
Save dirty documents before evaluating queries
dbartol Jun 21, 2023
de38b1f
Stop overriding saveBeforeStart for `ql` language
dbartol Jun 21, 2023
1da96c5
Allow `languageId:` scopes in tests
dbartol Jun 21, 2023
b182d7a
Fix PR feedback
dbartol Jun 21, 2023
0bd0bf1
_Correctly_ emulate VS Code's `saveBeforeStart`
dbartol Jun 22, 2023
2397ead
Fix test failure
dbartol Jun 22, 2023
6bdc095
Fix test failure
dbartol Jun 22, 2023
ec71f53
Fix more test failures
dbartol Jun 22, 2023
ff2d67d
Merge remote-tracking branch 'origin/main' into dbartol/save-before-s…
dbartol Jun 22, 2023
3705464
Seriously, I think they'll pass for reals this time.
dbartol Jun 22, 2023
d9a1aa8
Just kidding, _this_ time it's fixed for reals
dbartol Jun 22, 2023
8ff1db1
Fix bad diff
dbartol Jun 28, 2023
d27efb3
Merge remote-tracking branch 'origin/main' into dbartol/save-before-s…
dbartol Jun 29, 2023
adf0ccb
Disable workspace trust for CLI integration tests
dbartol Jun 29, 2023
9fd0697
Fix format
dbartol Jun 29, 2023
dbd257e
More logging
dbartol Jun 29, 2023
bf36051
Increase timeout
dbartol Jun 29, 2023
9f077b0
Run Jest in verbose mode
dbartol Jun 29, 2023
53a51ab
More logging
dbartol Jun 29, 2023
b859bca
Even more logging
dbartol Jun 30, 2023
1f5b391
Dump dirty documents
dbartol Jun 30, 2023
81b2407
Log content of untitled docs
dbartol Jun 30, 2023
c25410e
Log config settings
dbartol Jun 30, 2023
c70ec71
Try different default for saveBeforeStart
dbartol Jun 30, 2023
e80a06c
Try grabbing screenshot
dbartol Jun 30, 2023
6fc0a03
Always upload screenshots
dbartol Jun 30, 2023
eb3c0a2
Set default saveBeforeStart for QL
dbartol Jun 30, 2023
84d40fe
Log active language ID
dbartol Jun 30, 2023
2c69a31
More screenshots
dbartol Jun 30, 2023
53a0778
Back to previous timeout
dbartol Jun 30, 2023
cb3939e
Only create dirty files for commands that don't go through the VS Cod…
dbartol Jul 3, 2023
97715dc
Periodic screenshots
dbartol Jul 7, 2023
f17954f
Better periodic screenshots
dbartol Jul 7, 2023
a22a950
Fix unused
dbartol Jul 7, 2023
b18b3e5
Periodic screenshots step
dbartol Jul 7, 2023
e2e11cc
Screenshots
dbartol Jul 7, 2023
6d9a0e1
Use runner temp directory
dbartol Jul 11, 2023
e5dee84
Screenshots on Windows only
dbartol Jul 11, 2023
800f818
Add explanatory comment
dbartol Jul 11, 2023
6e17fda
Comment about temp directory
dbartol Jul 11, 2023
6b2373d
Delete unneeded files
dbartol Jul 11, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Even more logging
  • Loading branch information
dbartol committed Jun 30, 2023
commit b859bca25f95f09913b8a3c94a2b65d13d73e5b8
Original file line number Diff line number Diff line change
Expand Up @@ -67,18 +67,25 @@ async function compileAndRunQuery(
);

case "debug":
console.log("Running query in debug mode");
return await withDebugController(appCommands, async (controller) => {
console.log("Starting debugging");
await controller.startDebugging(
{
query: queryUri.fsPath,
},
true,
);
console.log("Waiting for launch");
await controller.expectLaunched();
console.log("Checking success");
const succeeded = await controller.expectSucceeded();
await controller.expectExited();
console.log("Terminating");
await controller.expectTerminated();
console.log("Closing session");
await controller.expectSessionClosed();
console.log("Done");

return succeeded.results;
});
Expand Down
Loading