C#: Order files in buildless extraction #16945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvitved
reviewed
Jul 10, 2024
| @@ -91,7 +91,9 @@ private IEnumerable<FileInfo> SelectSmallFiles(IEnumerable<FileInfo> files) | |||
| private FileInfo[] GetAllFiles() | |||
| { | |||
| logger.LogInfo($"Finding files in {SourceDir}..."); | |||
| var files = SourceDir.GetFiles("*.*", new EnumerationOptions { RecurseSubdirectories = true }); | |||
| var files = SourceDir | |||
There was a problem hiding this comment.
I'm surprised that GetFiles is not deterministic?
There was a problem hiding this comment.
It's a wild guess.
hvitved
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to make buildless extraction deterministic.
I've seen alert wobble in the following scenario: there are multiple source files in the repo with global statements, Roslyn chooses (hopefully by the syntax tree order in the compilation) one of the files to contain the generated
<Main>$, in the other files the global statements are not extracted.