Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go: Convert fasthttp sources to MaD #16960

Merged
merged 8 commits into from
Jul 17, 2024
Merged

Go: Convert fasthttp sources to MaD #16960

merged 8 commits into from
Jul 17, 2024

Conversation

owen-mc
Copy link
Contributor

@owen-mc owen-mc commented Jul 11, 2024

Convert sources from fasthttp to MaD.

I don't believe this needs a change note.

@owen-mc owen-mc added the no-change-note-required This PR does not need a change note label Jul 11, 2024
@owen-mc owen-mc requested a review from a team as a code owner July 11, 2024 13:39
@github-actions github-actions bot added the Go label Jul 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 11, 2024 •
edited
Loading

⚠️ The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

go

Generated file changes for go

  • Changes to framework-coverage-go.rst:
-    `fasthttp <https://github.com/valyala/fasthttp>`_,``github.com/valyala/fasthttp*``,,5,
+    `fasthttp <https://github.com/valyala/fasthttp>`_,``github.com/valyala/fasthttp*``,50,5,
-    Totals,,204,902,25
+    Totals,,254,902,25
  • Changes to framework-coverage-go.csv:
- github.com/valyala/fasthttp,,,5,,,,5,
+ github.com/valyala/fasthttp,,50,5,,,50,5,

@owen-mc owen-mc requested a review from egregius313 July 11, 2024 13:49
egregius313
egregius313 previously approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@egregius313 egregius313 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending fixing the provenance numbers in the test cases

@owen-mc owen-mc force-pushed the go/mad-sources-fasthttp branch 2 times, most recently from 9d6a159 to a12108c Compare July 17, 2024 11:01
@owen-mc
Adapt test to work better for MaD
f339274 
In MaD, `Argument[n]` corresponds to the post-update node of the
argument, which in the old version of the test will be the definition of
`dstReader` for the tests for `ReadBody`, `ReadLimitBody`,
`ContinueReadBodyStream`, `ContinueReadBody`.
@owen-mc
Convert Fasthttp::URI::RemoteFlowSource to MaD
5a00b5e
@owen-mc
Convert Fasthttp::Args::RemoteFlowSource to MaD
c3169d2
@owen-mc
Convert Fasthttp::Request::RemoteFlowSource to MaD
729069e
@owen-mc
Convert Fasthttp::RequestCtx::RemoteFlowSource to MaD
abeca3d
@owen-mc
Convert Fasthttp::RequestHeader::RemoteFlowSource to MaD
cfdd487
@owen-mc
Do not use "request" threat model kind
6b52cd4 
It is not supported yet.
egregius313
egregius313 approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@egregius313 egregius313 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@owen-mc owen-mc merged commit 433137a into github:main Jul 17, 2024
13 checks passed
@owen-mc owen-mc deleted the go/mad-sources-fasthttp branch July 17, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egregius313 egregius313 egregius313 approved these changes

Assignees
No one assigned
Labels
Go no-change-note-required This PR does not need a change note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@owen-mc @egregius313