C++: Fix cpp/iterator-to-expired-container FPs
#16915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d6c3500
to
0e6b2f0
Compare
geoffw0
approved these changes
Jul 8, 2024
My mistake. On further inspection it was simply a wobble. In any case, this shouldn't change the conclusion. So I'll merge and move on 🤠 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were missing a definition of the "address" of a SSA variable when the variable was represented by a call instruction. This was causing FPs on
cpp/iterator-to-expired-containeron some projects.This fixes the FP added in #16913.
The removed result on
cpp/type-confusionis also a FP that's now gone 🎉