-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C#: Do not skip extraction of already seen source files #16938
C#: Do not skip extraction of already seen source files #16938
Conversation
@@ -0,0 +1,2 @@ | |||
description: Add unique constraint on preprocessor directive and compilation pairs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need a downgrade script that picks a unique preprocessor directive?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need one, not having a unique value will result in DB inconsistencies, but I think that's acceptable.
6bb4d8c
to
a4e357e
Compare
I've rebased this PR and pushed an extra commit to it. I'll start a new DCA experiment... |
DCA shows 13.1% analysis time slowdown on |
@hvitved Could you reapprove this PR? |
No description provided.