Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Update Bazel rules_foreign_cc from 0.4.0 to 0.8.0." #628

Merged
merged 1 commit into from
Aug 3, 2022
Merged

Revert "Update Bazel rules_foreign_cc from 0.4.0 to 0.8.0." #628

merged 1 commit into from
Aug 3, 2022

Conversation

harsha-mandadi
Copy link
Collaborator

Reverts #624. Hitting multiple issues on Mac after rules_foreign_cc is upgraded to 0.8.0.

./lib/msvc-nothrow.c:25:10: fatal error: 'windows.h' file not found
#include <windows.h>

./lib/findprog-in.c:137:25: error: implicit declaration of function 'eaccess' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
                    if (eaccess (progpathname, X_OK) == 0)
                        ^
./lib/findprog-in.c:137:25: note: did you mean 'access'?
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/unistd.h:431:6: note: 'access' declared here
int      access(const char *, int);
         ^
./lib/findprog-in.c:211:21: error: implicit declaration of function 'eaccess' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
                if (eaccess (progpathname, X_OK) == 0)

@shaper
Copy link
Contributor

shaper commented Aug 3, 2022

Apologies, I'll file an issue to look into it. Can you let me know:

  1. Your mac CPU e.g. sysctl -a | grep brand may give it to you
  2. Your bazel version bazel --version

@shaper shaper merged commit 4b8355d into main Aug 3, 2022
@shaper shaper deleted the revert-624-update_rfcc branch August 3, 2022 19:29
@shaper shaper mentioned this pull request Aug 3, 2022
Open
@harsha-mandadi
Copy link
Collaborator Author

Following are the details about the machine on which we are seeing issues:
machdep.cpu.brand_string: Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz
machdep.cpu.brand: 0
bazel version: bazel 5.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaper shaper shaper approved these changes

@markww markww Awaiting requested review from markww

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harsha-mandadi @shaper