Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Including gin.torch and gin.tf #174

Closed
sjmikler opened this issue Nov 3, 2022 · 1 comment
Closed

Including gin.torch and gin.tf #174

sjmikler opened this issue Nov 3, 2022 · 1 comment

Comments

@sjmikler
Copy link

sjmikler commented Nov 3, 2022

Including import gin.torch or import gin.tf has no effect besides checking whether you have the package installed. To register package specific functions, you have to call import gin.torch.external_configurables, which is poorly documented.

So I suggest adding import external_configurables in gin.torch.__init__ and gin.tf.__init__.
@sjmikler
Copy link
Author

sjmikler commented Nov 3, 2022

After some more thinking, this is not totally unreasonable, just an author's choice I don't agree with. So I am closing the issue.

@sjmikler sjmikler closed this as not planned Won't fix, can't repro, duplicate, stale Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sjmikler