Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api: Don't treat 429 as error #2850

Merged
merged 2 commits into from
Jun 12, 2017
Merged

api: Don't treat 429 as error #2850

merged 2 commits into from
Jun 12, 2017

Conversation

vishalnayak
Copy link
Member

Fixes #2840

chrishoffman
chrishoffman approved these changes Jun 12, 2017
View reviewed changes
Copy link
Contributor

@chrishoffman chrishoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

jefferai
jefferai reviewed Jun 12, 2017
View reviewed changes
api/response.go Outdated
if r.StatusCode >= 200 && r.StatusCode < 400 {
// 200 to 399 are okay status codes. 429 is the code for health status of
// standby nodes.
if r.StatusCode >= 200 && r.StatusCode < 400 || r.StatusCode == 429 {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add parentheses to make it explicit for casual readers where the or/and precedence is taking place?

Otherwise LGTM.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@vishalnayak vishalnayak merged commit 1379053 into master Jun 12, 2017
@vishalnayak vishalnayak deleted the api-standby-health-resp branch June 12, 2017 22:31
@xorpaul xorpaul mentioned this pull request Aug 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jefferai jefferai jefferai left review comments

@chrishoffman chrishoffman chrishoffman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vishalnayak @jefferai @chrishoffman