Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow log level to be specified in an env var #3721

Merged
merged 1 commit into from
Dec 19, 2017
Merged

Allow log level to be specified in an env var #3721

merged 1 commit into from
Dec 19, 2017

Conversation

jefferai
Copy link
Member

No description provided.

@jefferai jefferai added this to the 0.9.1 milestone Dec 19, 2017
briankassouf
briankassouf reviewed Dec 19, 2017
View reviewed changes
command/server.go
if os.Getenv("VAULT_LOG_LEVEL") != "" {
logLevel = os.Getenv("VAULT_LOG_LEVEL")
}
if logLevelFlag != "" {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally env vars take precedence over config values, think this should too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't a config value, it's a flag -- which generally takes precedence over env vars :-)

@jefferai jefferai merged commit 706591e into master Dec 19, 2017
@jefferai jefferai deleted the envvar-log-level branch December 19, 2017 22:12
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calvn calvn calvn approved these changes

@briankassouf briankassouf briankassouf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9.1
Development

Successfully merging this pull request may close these issues.
3 participants
@jefferai @calvn @briankassouf