Store original request path in WrapInfo #3100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jefferai
reviewed
Aug 2, 2017
vault/wrapping.go
Outdated
| // Store creation_path if not a rewrap | ||
| if req.Path != "sys/wrapping/rewrap" { | ||
| cubbyReq.Data["creation_path"] = req.Path | ||
| } |
There was a problem hiding this comment.
otherwise this should be the wrapinfo creation path right?
briankassouf
reviewed
Aug 2, 2017
http/handler_test.go
Outdated
| @@ -282,6 +282,12 @@ func TestSysMounts_headerAuth_Wrapped(t *testing.T) { | |||
| } | |||
| expected["wrap_info"].(map[string]interface{})["creation_time"] = actualCreationTime | |||
|
|
|||
| actualCreationPath, ok := actual["wrap_info"].(map[string]interface{})["creation_path"] | |||
| if !ok || actualCreationPath == "" { | |||
| t.Fatal("creation_time missing in wrap info") | |||
calvn
commented
Aug 2, 2017
| @@ -58,7 +58,7 @@ $ curl \ | |||
| "token": "3b6f1193-0707-ac17-284d-e41032e74d1f", | |||
| "ttl": 300, | |||
| "creation_time": "2016-09-28T14:22:26.486186607-04:00", | |||
| "wrapped_accessor": "" | |||
There was a problem hiding this comment.
wrapped_accessor is not returned if it's empty.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3009