Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: terraform-aws-modules/terraform-aws-ecs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: hex-inc/terraform-aws-ecs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 7 commits
  • 1 file changed
  • 2 contributors

Commits on May 20, 2024

  1. Remove dict comprehension 

    Dict comprehension was causing the for_each to error if any setting,
either key or value was dynamic, disallowing use from setting envvars
created via other terraform resources.
    @Orisphere
    Orisphere committed May 20, 2024
    Configuration menu
    Copy the full SHA
    29e5354 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #1 from hex-inc/ca/20240520-fix-for-each 

    Remove dict comprehension
    @Orisphere
    Orisphere authored May 20, 2024
    Configuration menu
    Copy the full SHA
    ec95b30 View commit details
    Browse the repository at this point in the history

  3. Remove conditional entirely.

    @Orisphere
    Orisphere committed May 20, 2024
    Configuration menu
    Copy the full SHA
    04703fd View commit details
    Browse the repository at this point in the history

  4. Use only keys for for_each.

    @Orisphere
    Orisphere committed May 20, 2024
    Configuration menu
    Copy the full SHA
    4635366 View commit details
    Browse the repository at this point in the history

  5. Merge pull request #2 from hex-inc/ca/20240520-remove-conditional 

    Remove conditional
    @Orisphere
    Orisphere authored May 20, 2024
    Configuration menu
    Copy the full SHA
    f84046d View commit details
    Browse the repository at this point in the history

Commits on May 21, 2024

  1. Use count instead of for_each.

    @Orisphere
    Orisphere committed May 21, 2024
    Configuration menu
    Copy the full SHA
    7dc037f View commit details
    Browse the repository at this point in the history

  2. Merge pull request #3 from hex-inc/ca/20240521-use-count 

    Use count instead of for_each.
    @Orisphere
    Orisphere authored May 21, 2024
    Configuration menu
    Copy the full SHA
    a0e1b97 View commit details
    Browse the repository at this point in the history
Loading