Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xterm sixel support not detected automatically #191

Open
ploum opened this issue Feb 8, 2024 · 5 comments
Open

xterm sixel support not detected automatically #191

ploum opened this issue Feb 8, 2024 · 5 comments
Labels
compatibility Compatibility (e.g. terminal quirks) feature New feature or request

Comments

@ploum
Copy link

ploum commented Feb 8, 2024

using xterm 384 with xterm -ti vt340

happening:
chafa picture.jpg return pictures in symbols.
chafa -f sixels picture.jpg returns pictures in sixels (perfect quality)

expected:
with "-f sixels", chafa should recognize sixels support and use sixels by default

@ploum
Copy link
Author

ploum commented Feb 8, 2024

Oops, realized afterward that this was with chafa 1.12. Will test with 1.14 later.

@hpjansson
Copy link
Owner

I think the situation is the same in 1.14. XTerm used to default to having sixel support turned off - you had to enable VT340 support in order to get it, and I couldn't find a way to passively detect when this was the case. It looks like newer XTerm has it turned on. Do you know in which version this was changed, and how old it is?

@ploum
Copy link
Author

ploum commented Feb 8, 2024 via email

@hpjansson
Copy link
Owner

Looks like I was wrong about XTerm enabling support by default. xterm -ti vt340 seems to be required still on xterm-389. lsix is actively probing the terminal, which we're not yet doing (and which when implemented may still not work in all situations, like when we can't access the controlling terminal).

So the action item here is to implement active probing. I put some of the scaffolding in place in Chafa 1.14, so it may not be that far away.

@j4james
Copy link

j4james commented Mar 9, 2024

@hpjansson FYI, you can enable the graphics protocols in XTerm without "downgrading" to VT340 by setting the decGraphicsID resource. That's been an option since patch 357 if the logs are accurate.

@hpjansson hpjansson added feature New feature or request compatibility Compatibility (e.g. terminal quirks) labels Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility Compatibility (e.g. terminal quirks) feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants