Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace custom template engine with Jinja2 #230

Open
Thorsten-Sick opened this issue Dec 21, 2023 · 1 comment
Open

Replace custom template engine with Jinja2 #230

Thorsten-Sick opened this issue Dec 21, 2023 · 1 comment

Comments

@Thorsten-Sick
Copy link

Replacing the custom template engine with Jinja2 would remove a bunch of custom code.
Jinja2 is more powerful and flexible.

https://jinja.palletsprojects.com/en/2.10.x/

Early 2024 I would have time to do that and adjust the existing templates.

@izar
Copy link
Collaborator

izar commented Jan 5, 2024

This is a definite possibility for NG. The thing is that one of the basic premises of the project was to have as little external dependencies as possible - but it might be time to move away from that.

Also, about the plugin engine - I think we should definitely go to NG with it, what do you SAY @colesmj ? My worry is to end up with two ways of having rules and making it more difficult for people to add rules, without clear reasoning. I'd prefer a clean break and move to the new ways, leaving people on 1.x if they prefer that functionality rather than potentially breaking running stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants