Draft: multiple mapping values #3484
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mapping-values # Conflicts: # backend/src/main/java/com/bakdata/conquery/models/types/ResultType.java
…multiple values are allow, we overwrite the entire string
thoniTUB
reviewed
Jul 29, 2024
There was a problem hiding this comment.
Kannst du hier bitte noch mit TAB einrücken?
| @@ -16,10 +16,11 @@ public interface InternToExternMapper extends NamespacedIdentifiable<InternToExt | |||
|
|
|||
| boolean initialized(); | |||
|
|
|||
| String external(String internalValue); | |||
| ResultType<?> createMappedType(boolean list); | |||
Comment on lines
+245
to
+246
| @Data | ||
| public static class MappedMultiStringT extends ResultType<List<String>> { |
There was a problem hiding this comment.
Ich denke mit diesen Klassen wird das ResultType System weniger definiert und wird sollten überlegen, wie man dass besser refactored, so dass die Logik für das erstellen des Ergebisses aus dem ResultType heraus wandert und näher am Select und seinem Mapping drannen ist.
Mir fällt das erst jetzt auf, dass wir durch abschaffen des CPSTypes in der Klasse, auch implizite Konventionen abgeschafft haben.
public String typeInfo() {
return "LIST[STRING]";
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ich glaube, dass das einen ziemlich krassen Rattenschwanz haben wird und wir das Feature nicht umsetzen sollten.