always use HTTPS getting mathjax from CDN #6249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Definitely should be done, and should be backported to the 0.13.x, 1.x, and 2.x series to make it simpler for all the distros (they ended up patching the old versions). |
takluyver
added a commit
that referenced
this pull request
Jul 31, 2014
always use HTTPS getting mathjax from CDN
|
As long as it does not confort user in thinking over http is secure.. even on localhost. |
|
This won't be transparent to the user, just mitigate external resources from having an attack point against their local box. |
takluyver
added a commit
that referenced
this pull request
Aug 1, 2014
Is there any reason not to do this now? closes #6246
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
always use HTTPS getting mathjax from CDN
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there any reason not to do this now?
closes #6246