Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update librealsense to v2.54.2 #6714

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Update librealsense to v2.54.2 #6714

wants to merge 16 commits into from

Conversation

sitic
Copy link
Contributor

@sitic sitic commented Mar 24, 2024

Type

  • Bug fix (non-breaking change which fixes an issue): Fixes #
  • New feature (non-breaking change which adds functionality). Resolves #
  • Breaking change (fix or feature that would cause existing functionality to not work as expected) Resolves #

Motivation and Context

Update to latest librealsense version for PR

Checklist:

  • I have run python util/check_style.py --apply to apply Open3D code style
    to my code.
  • This PR changes Open3D behavior or adds new functionality.
    • Both C++ (Doxygen) and Python (Sphinx / Google style) documentation is
      updated accordingly.
    • I have added or updated C++ and / or Python unit tests OR included test
      results       (e.g. screenshots or numbers) here.
  • I will follow up and update the code if CI fails.
  • For fork PRs, I have selected Allow edits from maintainers.

Description

I've browed through the librealsense Release Notes and didn't see any relevant breaking changes listed.

@update-docs Update Docs
Copy link

update-docs bot commented Mar 24, 2024

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

@sitic sitic marked this pull request as draft March 24, 2024 05:07
@ssheorey ssheorey self-requested a review March 24, 2024 21:42
@sitic sitic mentioned this pull request Mar 24, 2024
Merged
9 tasks
@ssheorey
Copy link
Member

Only Windows CI has errors now.

@ssheorey ssheorey added the io label Apr 28, 2024
@ssheorey ssheorey added this to the v0.19 milestone Apr 29, 2024
@ssheorey ssheorey marked this pull request as ready for review June 16, 2024 05:27
@ssheorey ssheorey force-pushed the realsense branch 2 times, most recently from acbb631 to 6c71ba8 Compare July 9, 2024 22:13
@StephanTLavavej
Copy link

FYI, you're passing --allow-unsupported-compiler to CUDA 11.7 as an escape hatch because CUDA 12.4 was the first version that allowed VS 2022 17.10+. However, you're still getting an error because VS 2022 17.11 began requiring CUDA 12.4, and MSVC's STL is emitting a compiler error when it detects that.

The proper fix is to upgrade to CUDA 12.4 or later. The MSVC STL escape hatch is to define _ALLOW_COMPILER_AND_STL_VERSION_MISMATCH . That will skip emitting error STL1002 "Unexpected compiler version, expected CUDA 12.4 or newer." However, this puts you into an unsupported state (we require CUDA 12.4 for its fixes and features), so you may encounter other errors for which there are no possible escape hatches.

(I work on MSVC's STL. The version requirement history is documented at https://github.com/microsoft/STL/wiki/Macro-_MSVC_STL_UPDATE .)

@StephanTLavavej StephanTLavavej mentioned this pull request Nov 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssheorey ssheorey ssheorey approved these changes

Assignees
No one assigned
Labels
io
Projects
None yet
Milestone
v0.19
Development

Successfully merging this pull request may close these issues.
3 participants
@sitic @ssheorey @StephanTLavavej