Pick up changes to CRD template naming and fix excessive WG validation #3295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤔 🐛 You appear to be fixing a bug in Go code, yet your PR doesn't include updates to any test files. Did you forget to add a test? Courtesy of your friendly test nag. |
howardjohn
commented
Aug 19, 2024
| @@ -109,6 +109,7 @@ message WorkloadGroup { | |||
| // should default to `default`. The workload identities (mTLS certificates) will be bootstrapped using the | |||
| // specified service account's token. Workload entries in this group will be in the same namespace as the | |||
| // workload group, and inherit the labels and annotations from the above `metadata` field. | |||
| // +protoc-gen-crd:validation:IgnoreSubValidation:["Address is required"] | |||
There was a problem hiding this comment.
This is the meat of the change, rest is just find+replace
2 tasks
linsun
approved these changes
Aug 19, 2024
|
LG, pending tests passing. |
|
/test all |
|
/retest |
howardjohn
added a commit
to howardjohn/api
that referenced
this pull request
Aug 20, 2024
Master PR istio#3295 Fixes istio/istio#52749
dhawton
approved these changes
Aug 20, 2024
istio-testing
pushed a commit
that referenced
this pull request
Aug 21, 2024
Master PR #3295 Fixes istio/istio#52749
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes istio/istio#52749