-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Insert Git commit hash into build artifacts #59
Conversation
Relates to #7 |
Add Eclipse-SourceReference headers (issue #7)
Header looks good to me -- but does not work for Eclipse. If I try to import a plug-in built with the new header from the repository I get the error message "The plug-ins do not have an Eclipse-SourceReferences manifest header that can be processed". I'll investigate. |
Hm, FYI I took an example from https://bugs.eclipse.org/bugs/show_bug.cgi?id=380691 |
Ok, I give up. I wasn't able to import any project with a git URL, not even a org.eclipse project. So this seems not to be our problem. -> We can merge this. |
@marchof Seems that this feature is a part of EGit 2.0 and requires Eclipse 4.2 - see http://wiki.eclipse.org/EGit/New_and_Noteworthy/2.0#Support_for_Eclipse-SourceReferences_manifest_headers |
I tried EGit 2.2 but on Eclipse 3.8.1. |
@marchof I was able to successfully test this feature from this branch with a fresh installation of Eclipse 4.2.1. |
Done in 4a77e40 |
For better source traceability we should insert the Git commit hash into the build artifacts:
A shortened hash can then be used for the JaCoCo runtime identifier.