Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insert Git commit hash into build artifacts #59

Closed
wants to merge 4 commits into from
Closed

Conversation

Godin
Copy link
Member

@Godin Godin commented Dec 24, 2012

For better source traceability we should insert the Git commit hash into the build artifacts:

  • As a MANIFEST.MF header in all JARs
  • Into index.html (linked with Github)

A shortened hash can then be used for the JaCoCo runtime identifier.

@ghost ghost assigned Godin Dec 24, 2012
@Godin
Copy link
Member

Godin commented Dec 24, 2012

Relates to #7

Add Eclipse-SourceReference headers (issue #7)
@Godin
Copy link
Member

Godin commented Dec 24, 2012

@marchof Could you please verify my changes? Generated JAR files now should contain Eclipse-SourceReference entry with proper "commitId" (issue #7), but index.html wasn't modified as I'm not sure what you wanted to change in it.

@marchof
Copy link
Member Author

marchof commented Dec 25, 2012

Header looks good to me -- but does not work for Eclipse. If I try to import a plug-in built with the new header from the repository I get the error message "The plug-ins do not have an Eclipse-SourceReferences manifest header that can be processed". I'll investigate.

@Godin
Copy link
Member

Godin commented Dec 25, 2012

Hm, FYI I took an example from https://bugs.eclipse.org/bugs/show_bug.cgi?id=380691

@marchof
Copy link
Member Author

marchof commented Dec 25, 2012

Ok, I give up. I wasn't able to import any project with a git URL, not even a org.eclipse project. So this seems not to be our problem. -> We can merge this.

@Godin
Copy link
Member

Godin commented Dec 25, 2012

@marchof Seems that this feature is a part of EGit 2.0 and requires Eclipse 4.2 - see http://wiki.eclipse.org/EGit/New_and_Noteworthy/2.0#Support_for_Eclipse-SourceReferences_manifest_headers

@marchof
Copy link
Member Author

marchof commented Dec 25, 2012

I tried EGit 2.2 but on Eclipse 3.8.1.

@Godin
Copy link
Member

Godin commented Dec 26, 2012

@marchof I was able to successfully test this feature from this branch with a fresh installation of Eclipse 4.2.1.

Godin added a commit that referenced this pull request Dec 26, 2012
@Godin
Copy link
Member

Godin commented Dec 26, 2012

Done in 4a77e40

@Godin Godin closed this Dec 26, 2012
@Godin Godin deleted the issue-59 branch December 26, 2012 11:01
@jacoco jacoco locked and limited conversation to collaborators Jan 11, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants