Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename __constraints attribute to __cloup_constraints__ #132

Merged
merged 1 commit into from
Nov 5, 2022
Merged

Rename __constraints attribute to __cloup_constraints__ #132

merged 1 commit into from
Nov 5, 2022

Conversation

pocek
Copy link
Contributor

@pocek pocek commented Nov 5, 2022

Unlike __constraints, __cloup_constraints__ is not name-mangled which allows for easier access if needed.

Fixes #131.

@pocek
Rename __constraints attribute to __cloup_constraints__
13c4073 
Unlike __constraints, __cloup_constraints__ is not name-mangled which
allows for easier access if needed.

Fixes #131.
@janluke
Copy link
Owner

janluke commented Nov 5, 2022 •
edited
Loading

Thanks for the PR! :)

Note: I won't consider this a breaking change since I considered __constraints private API (as expressed by the variable name). On the other hand, __cloup_constraints__ is public API. Thus, I'll release this in v1.1.0.

@janluke janluke merged commit 936ea0d into janluke:master Nov 5, 2022
@janluke janluke added the enhancement New feature or request label Nov 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider renaming __constraints to __cloup_constraints__
2 participants
@pocek @janluke