Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remarker appears to be the cause of crashes in VS 15.8 #6

Open
AdamDotNet opened this issue Aug 15, 2018 · 12 comments
Open

Remarker appears to be the cause of crashes in VS 15.8 #6

AdamDotNet opened this issue Aug 15, 2018 · 12 comments

Comments

@AdamDotNet
Copy link

With the Remarker extension enabled, VS crashes upon trying to open any SLN.

I disable Remarker, VS stops crashing upon opening any SLN. Re-enabling Remarker gets VS to crash again. Not sure who is at fault here, but trying to be helpful by reporting to both parties involved.

VS Error Report:
https://developercommunity.visualstudio.com/content/problem/311694/extensions-that-fail-to-load-crash-visual-studio.html

Thanks!

@seangifford
Copy link

I've experienced the same problem. Here is the relevant ActivityLog.xml entry:

1310 2018/08/16 17:03:38.759 Error Editor or Editor Extension System.NullReferenceException: Object reference not set to an instance of an object. at YoderZone.Extensions.Remarker.RemarkTagger.GetTags(NormalizedSnapshotSpanCollection spans) at Microsoft.VisualStudio.Text.Tagging.Implementation.TagAggregator`1.<GetTagsForBuffer>d__39.MoveNext() --- End of stack trace from previous location where exception was thrown --- at Microsoft.VisualStudio.Telemetry.WindowsErrorReporting.WatsonReport.GetClrWatsonExceptionInfo(Exception exceptionObject)

@stefangavrilasengage
Copy link

Can confirm this is happening to me as well. ActivityLog says the same thing as above :
Extension System.NullReferenceException: Object reference not set to an instance of an object. at YoderZone.Extensions.Remarker.RemarkTagger.GetTags(NormalizedSnapshotSpanCollection spans) at Microsoft.VisualStudio.Text.Tagging.Implementation.TagAggregator`1.d__39.MoveNext() --- End of stack trace from previous location where exception was thrown --- at Microsoft.VisualStudio.Telemetry.WindowsErrorReporting.WatsonReport.GetClrWatsonExceptionInfo(Exception exceptionObject)

@AdamDotNet
Copy link
Author

@seangifford or @stefangavrilasengage
My activitylog.xml didn't contain the crash, can one of you add a comment and upload your entire activitylog.xml to the linked VS bug report? Additional info was requested by Microsoft there.

@madskristensen
Copy link

Repro Steps:

  1. Install Remarker extension, version 1.4.
  2. Create an ASP .Net web application.
  3. Close VS and Reopen VS.
  4. Open a file or a solution ,such as c# console application.

Expected:
a c# console app will be create successfully.

Actually:
a c# console app not be create successfully and vs crash.

@kirbatious
Copy link

I can confirm the same issue. Any progress figuring out a solution? I miss it!

@stefangavrilasengage
Copy link

I uninstalled & reinstalled a previous version to make this work and it does the job (currently using 15.7.6).

@Stefano-Rascio
Copy link

I confirm it too

@djspider117
Copy link

Any update on this, and does it crash on 15.9.x?

@kirbatious
Copy link

I just updated to 15.9.4 and tried again, but the issue still remains

@tgaldi
Copy link

tgaldi commented Dec 12, 2018

@kirbatious
Copy link

Thanks for this link @tgaldi and to @negrutiu for the work.

It feels such a shame to have to switch from a package on the VS marketplace to downloading a vsix from github but given that @jgyo has been so silent on this critical bug I guess it's the only option.

I haven't tried it out yet and will review the commits to make sure that one of the very sensible looking commits doesn't include a bitcoin mining bot or whatever, but I assume you can vouch that it works @tgaldi?

@negrutiu
Copy link

Hey guys, I didn't know about this thread...
@kirbatious : you're welcome to review my commits. I promise you there's no miner or anything malicious hidden there :)
Enjoy Remarker!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants