-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement add/1
#3144
Implement add/1
#3144
Conversation
I like it. What do other ppl say? from the original issue there was also talk about generator variants of |
add
/min
/max
Done |
Adding a stream-oriented Adding stream-oriented versions of min, max, min_by, and max_by would be fine, but it seems to me that existing implementations in C should be retained, both for the sake of efficiency and perhaps to facilitate future C-oriented development. Maybe the best would be to have one narrowly focused PR for |
It looks like Perhaps it would be prudent to discuss the best approach for For now, I'll revert this PR to focus solely on |
add
/min
/max
add/1
Friendly ping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Improves the ergonomics of
add
by avoiding the need for wrapper arrays. Assignments should be easier now too:Related to #2595