Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move closer to the standard autotools idiom. #3187

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dag-erling
Copy link

  • Create src/config.h instead of passing everything on the compiler command line.

  • To reduce the magnitude of this change, add --include src/config.h to CFLAGS instead of adding #include "src/config.h" at the top of each source file. Not all compilers support this, but I don't think we care about anything other than gcc and clang at this point.

  • Rather than generate src/config_opts.inc, emit JQ_CONFIG directly into src/config.h.

  • Rather than generate src/version.h, define JQ_VERSION as an alias for the standard PACKAGE_VERSION.

* Create `src/config.h` instead of passing everything on the compiler
  command line.

* To reduce the magnitude of this change, add `--include src/config.h`
  to CFLAGS instead of adding `#include "src/config.h"` at the top of
  each source file.  Not all compilers support this, but I don't think
  we care about anything other than gcc and clang at this point.

* Rather than generate `src/config_opts.inc`, emit `JQ_CONFIG` directly
  into `src/config.h`.

* Rather than generate `src/version.h`, define `JQ_VERSION` as an alias
  for the standard `PACKAGE_VERSION`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant