Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup unused fn IsValidServiceAccountKeyFile in authenticator config #126342

Merged
merged 1 commit into from
Aug 14, 2024
Merged

cleanup unused fn IsValidServiceAccountKeyFile in authenticator config #126342

merged 1 commit into from
Aug 14, 2024

Conversation

aramase
Copy link
Member

@aramase aramase commented Jul 24, 2024

/kind cleanup

cleanup unused function IsValidServiceAccountKeyFile in authenticator config

NONE

/sig auth
/triage accepted
/priority important-longterm

@aramase
cleanup unused fn IsValidServiceAccountKeyFile in authenticator config
71d7e29 
Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/auth Categorizes an issue or PR as relevant to SIG Auth. triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Jul 24, 2024
@k8s-ci-robot k8s-ci-robot requested review from deads2k and enj July 24, 2024 21:38
@stlaz
Copy link
Member

stlaz commented Jul 31, 2024

/lgtm
This is just a leftover from b8be627

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 31, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4747382acc3f616d186d0332a29fe49adae67473

@enj
Copy link
Member

enj commented Aug 2, 2024

/lgtm
/approve
/milestone v1.32

@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Aug 2, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aramase, enj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 2, 2024
@k8s-ci-robot k8s-ci-robot merged commit bbd1dd8 into kubernetes:master Aug 14, 2024
14 checks passed
@aramase aramase deleted the aramase/c/auth_rm_unused_function branch August 14, 2024 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@enj enj Awaiting requested review from enj

Assignees

@stlaz stlaz

@enj enj

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Auth
Status: Closed / Done
Milestone
v1.32
Development

Successfully merging this pull request may close these issues.
4 participants
@aramase @stlaz @k8s-ci-robot @enj