Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example code in ReadMe won't run. #76

Open
Julian-O opened this issue Dec 13, 2023 · 0 comments
Open

Example code in ReadMe won't run. #76

Julian-O opened this issue Dec 13, 2023 · 0 comments

Comments

@Julian-O
Copy link

The Readme contains some example code.

One example demonstrates that servers are also clients:

  • It imports time.sleep() but never uses it. Meanwhile, it uses time.time() without importing it.
  • It has a variable called cont which is never defined.
  • It does a busy wait, which is not demonstrating a good way to use the API.
  • It keeps appending True to a list (Why not just count?), but never popping it.
  • ping takes parameters, but it isn't clear what they represent.
  • pong doesn't use the *parameter. Rename it _.

One example demonstrates that async servers.

  • It imports OSCThreadServer but uses OSCAsyncServer

One example demonstrates how Unicode is used.

  • Uses OSCThreadServer without importing.
  • Uses send_message() without the expected osc. prefix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant