-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: categorize QA engine questions #1100
feat: categorize QA engine questions #1100
Conversation
Signed-off-by: Soumil Paranjpay <soumil.paranjpay@gmail.com>
Thanks for making a pull request! 😃 |
Signed-off-by: Soumil Paranjpay <soumil.paranjpay@gmail.com>
question keys Signed-off-by: Soumil Paranjpay <soumil.paranjpay@gmail.com>
Signed-off-by: Soumil Paranjpay <soumil.paranjpay@gmail.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1100 +/- ##
==========================================
+ Coverage 14.83% 14.93% +0.09%
==========================================
Files 87 89 +2
Lines 8248 8197 -51
==========================================
Hits 1224 1224
+ Misses 6705 6654 -51
Partials 319 319 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Soumil Paranjpay <soumil.paranjpay@gmail.com>
Signed-off-by: Soumil Paranjpay <soumil.paranjpay@gmail.com>
Signed-off-by: Soumil Paranjpay <soumil.paranjpay@gmail.com>
Signed-off-by: Soumil Paranjpay <soumil.paranjpay@gmail.com>
Hi @Soumil-07, last week while you were demoing the categorizing QA feature I think we had found a bug- when categories were specified in a new question in custom starlark-based transformer and they were not getting reflected during the QA in transform phase, and it was still showing as |
Hi! Apparently it wasn't a bug, I was using the wrong attribute during our demo (I used The corresponding Starlark code:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Soumil-07 can you rebase this branch as it is out-of-date with the main branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rebased automatically on Github
Related #861 |
Categorizes QA questions as defined by a new mappings file. Adds two flags: --qa-enable and --qa-disable for finer grained control