Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: when using --qa-enable and --qa-disable the answers to disabled questions were not being added to the generated config file #1163

Merged
merged 2 commits into from
Mar 21, 2024
Merged

fix: when using --qa-enable and --qa-disable the answers to disabled questions were not being added to the generated config file #1163

merged 2 commits into from
Mar 21, 2024

Conversation

HarikrishnanBalagopal
Copy link
Contributor

No description provided.

@HarikrishnanBalagopal HarikrishnanBalagopal added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Mar 21, 2024
@HarikrishnanBalagopal HarikrishnanBalagopal linked an issue Mar 21, 2024 that may be closed by this pull request
bug: answers to questions belonging to disabled categories don't get added to the generated config file #1161
Closed
@github-actions GitHub Actions
Copy link

Thanks for making a pull request! 😃
One of the maintainers will review and advise on the next steps.

@github-actions github-actions bot added fix and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Mar 21, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 21, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 7.14286% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 14.83%. Comparing base (d049f65) to head (820b163).

❗ Current head 820b163 differs from pull request most recent head 7870e43. Consider uploading reports for the commit 7870e43 to get more accurate results

Files Patch % Lines
qaengine/engine.go 7.14% 12 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1163      +/-   ##
==========================================
- Coverage   14.84%   14.83%   -0.01%     
==========================================
  Files          90       90              
  Lines        8367     8379      +12     
==========================================
+ Hits         1242     1243       +1     
- Misses       6802     6813      +11     
  Partials      323      323

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HarikrishnanBalagopal HarikrishnanBalagopal force-pushed the fix/qadisable branch 3 times, most recently from 1a6956b to 283afd2 Compare March 21, 2024 18:11
@HarikrishnanBalagopal
fix: when using --qa-enable and --qa-disable the answers to disabled …
820b163 
…questions were not being added to the generated config file

Signed-off-by: Harikrishnan Balagopal <harikrishmenon@gmail.com>
@HarikrishnanBalagopal
fixup! fix: when using --qa-enable and --qa-disable the answers to di…
7870e43 
…sabled questions were not being added to the generated config file

Signed-off-by: Harikrishnan Balagopal <harikrishmenon@gmail.com>
@HarikrishnanBalagopal HarikrishnanBalagopal enabled auto-merge (squash) March 21, 2024 18:30
@HarikrishnanBalagopal HarikrishnanBalagopal merged commit 7383e91 into konveyor:main Mar 21, 2024
3 checks passed
@HarikrishnanBalagopal HarikrishnanBalagopal deleted the fix/qadisable branch March 21, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashokponkumar ashokponkumar ashokponkumar approved these changes

@seshapad seshapad Awaiting requested review from seshapad

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: answers to questions belonging to disabled categories don't get added to the generated config file
2 participants
@HarikrishnanBalagopal @ashokponkumar