[3.x] fix: default date casting #1842
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Marking as draft until #1831 is merged |
a1dc8ad
to
8bedb5e
Compare
8bedb5e
to
137731f
Compare
137731f
to
e4006d7
Compare
e4006d7
to
23e5e58
Compare
23e5e58
to
cdaea6b
Compare
cdaea6b
to
f3965d3
Compare
|
@canvural, I've rebased and tests are passing, can this be merged? This just switches the checks around so that if there's an explicit cast for a date it will use the cast instead of the default date cast. |
f3965d3
to
b2723d9
Compare
b2723d9
to
e41b26c
Compare
|
Yes, all this does is just switch the if conditions around to respect the user's custom cast if there is one |
39d60e2
to
c4d0ee6
Compare
e41b26c
to
7b36005
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Closes #1744
Note, this depends on #1831 as that PR refactored the model property logic into a helper class.
Thanks!