-
-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Infer type of auth()->authenticate() and Auth::authenticate() calls #1957
base: 2.x
Are you sure you want to change the base?
Conversation
788a3d7
to
3746512
Compare
3746512
to
5c58c3c
Compare
42c61c9
to
a1a6569
Compare
@calebdw how would you deal with the change from |
It depends, if you need to correct the types then you would need to create new versioned stubs (look in the If the types are correct and you're just having issues with asserting the type returned from a method, then you'll have to only include your assertion files for certain versions. For example, in the GeneralTypeTest: |
994c62b
to
cb654ba
Compare
Thanks @calebdw, I'll keep that in mind for next time. I think I'll leave it as is as there isn't any larastan logic applied to loginById |
39d60e2
to
c4d0ee6
Compare
Changes
Add return type detection to
Auth::authenticate()
auth()->authenticate()
Breaking changes