New rule: Ensure access to defined filesystems #1989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is very nice PR. |
calebdw
reviewed
Jul 8, 2024
| { | ||
| public function getStorage(): Storage | ||
| { | ||
| return Storage::disk('local'); |
There was a problem hiding this comment.
There's no need to have two separate test files, you can add both lines in this test (rename the file of course, and there's no need for there to be a class) and just assert that the appropriate line throws the error:
The test file can be as simple as:
<?php
declare(strict_types=1);
use Illuminate\Support\Facades\Storage;
function test(): void
{
Storage::disk('local');
Storage::disk('this-is-not-defined');
}There was a problem hiding this comment.
and maybe a variable: Storage::disk($_GET['disk']);
calebdw
reviewed
Jul 8, 2024
Comment on lines
+31
to
+33
| public function __construct(protected ReflectionProvider $reflectionProvider) | ||
| { | ||
| } |
There was a problem hiding this comment.
This is not needed and can be removed
39d60e2
to
c4d0ee6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added a rule that ensures access to a defined filesystem or 'disk' configured in
config/filesystems.phpwhen using Laravel Storage abstraction API.Breaking changes
No breaking changes.