feat: useContainerCommandLoader parameter #2060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szepeviktor
approved these changes
Oct 8, 2024
|
Changed definition to one line to fix phpcs @szepeviktor all other failing checks seems not that change related to me. |
calebdw
reviewed
Oct 8, 2024
Comment on lines
38
to
40
| if ($this->useContainerCommandLoader) { | ||
| $consoleApplication->setContainerCommandLoader(); | ||
| } |
There was a problem hiding this comment.
Why do we really need another config option? I think this can just be appended on the getApplication() method below:
if ($this->application === null) {
$this->application = (new Application(app(Container::class), app(Dispatcher::class), app()->version()))
->setContainerCommandLoader();
}This is essentially what the framework does, and I see no reason why anyone would want to disable this:
There was a problem hiding this comment.
Well probably it makes sense, wanted to keep it without it to make sure we don't break anything but I will change it.
calebdw
reviewed
Oct 8, 2024
extension.neon
Outdated
There was a problem hiding this comment.
Make sure to clean up these changes as well (same as the laravel-test.sh file)
|
Hey @szepeviktor @calebdw when it can be merged? |
|
Not by me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
ContainerCommandLoaderwhen resolving command options/arguments etc, so when using#[AsCommand]attribute on commands it will work as expected and resolve options/arguments properlyBreaking changes
No breaking changes, added new parameter with false value