Hi @wangweiao, I have two questions in order to better understand this issue:

1. What Liquibase version were you using before updating to 4.29.2?
2. Would you be able to run liquibase update-sql and send us the resulting code? Feel free to remove the procedure's logic if it contains sensitive information.

Thank you,
Tatiana

Hi @tati-qalified ,

1. We were previously using Liquibase version 4.27.0 before updating to 4.29.2.
2. Here is the result after running liquibase update-sql:

create function foo() returns trigger AS;
begin
...
end;
language plpgsql;

create trigger 
...
execute procedure foo();

Best regards,
Weiao

@wangweiao it seems that Liquibase is interpreting the $$ that mark the beginning and ending of the function, as end delimiters. You can see this change in the generated code.

For 4.27.0:

create function foo() returns trigger AS 
            $$
            begin
            ...
            end;
            $$ language plpgsql;

For 4.28.0 through 4.29.2:

create function foo2() returns trigger AS;

begin
            
            ...
            end;

language plpgsql;

So now it's separating the "create" sentence from the function definition. This happens since Liquibase version 4.28.0.

We'll be looking into this. If you'd be willing to submit a PR to propose a fix, feel free to do so!

Thank you,
Tatiana

Hi Wang (@wangweiao),

If I'm not wrong this is working as expected. Recently, some endDelimiter issues have been fixed and this reported case seems to be behaving correctly. If we use $$ this is going to split your function in multiple statements like the ones below:

Statement 1:

create function foo() returns trigger AS 

Statement 2:

begin
...
end;

Statement 3:

language plpgsql;

create trigger
... 
execute procedure foo();

Then execution of statement one is not a valid SQL to create a function, so the returned error seems okay to us.

Thanks,
Daniel.