Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI tests failing due to new version of flake8 #1240

Closed
ich199 opened this issue Aug 10, 2023 · 0 comments
Closed

CI tests failing due to new version of flake8 #1240

ich199 opened this issue Aug 10, 2023 · 0 comments

Comments

@ich199
Copy link

ich199 commented Aug 10, 2023

A new version (6.1.0) of flake8 was released 2 weeks ago (29 July 2023) and seems to be causing the flake8 CI check to fail for existing tests:

$ pip list
Package     Version
----------- -------
flake8      6.1.0
mccabe      0.7.0
pip         23.2.1
pycodestyle 2.11.0
pyflakes    3.1.0
setuptools  62.6.0

$ flake8 .  
./tests/test_crypto.py:1745:16: E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()`
./tests/test_crypto.py:3153:16: E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()`
./tests/test_crypto.py:3448:16: E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()`
./tests/test_crypto.py:3449:16: E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()`
./tests/test_ssl.py:194:8: E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()`

$ echo $?
1

The previous version (6.0.0) used by the CI check passes:

$ pip list
Package     Version
----------- -------
flake8      6.0.0
mccabe      0.7.0
pip         23.2.1
pycodestyle 2.10.0
pyflakes    3.0.1
setuptools  62.6.0

$ flake8 .

$ echo $?
0

CI job from 2 weeks ago: https://github.com/pyca/pyopenssl/actions/runs/5701250353/job/15451784196#step:5:22

vs

current CI job: https://github.com/pyca/pyopenssl/actions/runs/5822365531/job/15786833735?pr=1239#step:5:22

@alex alex closed this as completed Sep 5, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

2 participants