Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix torch._C submodules population #133919

Closed
wants to merge 2 commits into from
Closed

Fix torch._C submodules population #133919

wants to merge 2 commits into from

Conversation

malfet
Copy link
Contributor

@malfet malfet commented Aug 19, 2024 •
edited
Loading

This fixes regression introduced by #132216 that on some Python runtimes failed with

>   from torch._C._dynamo.guards import GlobalStateGuard
E   ModuleNotFoundError: No module named 'torch._C._dynamo.guards'; 'torch._C._dynamo' is not a package

c:\users\malfet\git\pytorch\torch\_dynamo\convert_frame.py:28: ModuleNotFoundError

Simplify it by always registering submodules by its primary name and do not try to add submodules which are not part of the same namespace as parent. Otherwise module can be registered by alias, rather than by primary name.

@malfet
Fix torch._C submodules population
6867f5f 
This fixes regression introduced by #132216 that on some Python runtimes failed with 
```
from torch._C._dynamo.guards import GlobalStateGuard fails with
```
>   from torch._C._dynamo.guards import GlobalStateGuard
E   ModuleNotFoundError: No module named 'torch._C._dynamo.guards'; 'torch._C._dynamo' is not a package

c:\users\malfet\git\pytorch\torch\_dynamo\convert_frame.py:28: ModuleNotFoundError
```
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Aug 19, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/133919

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 4074438 with merge base 14ddd93 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

@malfet has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@malfet has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@malfet malfet added ciflow/trunk Trigger trunk jobs on your pull request topic: not user facing topic category release notes: python_frontend python frontend release notes category topic: improvements topic category and removed topic: not user facing topic category labels Aug 19, 2024
albanD
albanD approved these changes Aug 20, 2024
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge -f 'Landed internally'

(Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@malfet malfet deleted the malfet-patch-5 branch August 22, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@albanD albanD albanD approved these changes

@atalman atalman atalman approved these changes

@XuehaiPan XuehaiPan XuehaiPan approved these changes

@izaitsevfb izaitsevfb izaitsevfb approved these changes

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: python_frontend python frontend release notes category topic: improvements topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@malfet @facebook-github-bot @pytorchmergebot @Skylion007 @albanD @atalman @XuehaiPan @izaitsevfb