Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEPR: Index.is_monotonic for Index.is_monotonic_increasing #45422

Merged
merged 12 commits into from
Jan 23, 2022
Merged

DEPR: Index.is_monotonic for Index.is_monotonic_increasing #45422

merged 12 commits into from
Jan 23, 2022

Conversation

mroeschke
Copy link
Member

@mroeschke mroeschke commented Jan 17, 2022 •
edited
Loading

@mroeschke mroeschke added the Deprecate Functionality to remove in pandas label Jan 17, 2022
jbrockmendel
jbrockmendel reviewed Jan 17, 2022
View reviewed changes
pandas/core/base.py Outdated Show resolved Hide resolved
jbrockmendel
jbrockmendel reviewed Jan 17, 2022
View reviewed changes
pandas/core/groupby/ops.py
@@ -823,7 +823,7 @@ def groups(self) -> dict[Hashable, np.ndarray]:
@cache_readonly
def is_monotonic(self) -> bool:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deprecate here too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll try to address this one in another pass. This appears to be a private-ish version for groupby specifically.

@jbrockmendel
Copy link
Member

closes #21335 i think

@mroeschke mroeschke added this to the 1.5 milestone Jan 19, 2022
@jreback jreback mentioned this pull request Jan 22, 2022
Closed
@jreback jreback merged commit acd7218 into pandas-dev:main Jan 23, 2022
@jreback
Copy link
Contributor

jreback commented Jan 23, 2022

thanks @mroeschke

@mroeschke mroeschke deleted the depr/is_monotonic branch January 23, 2022 03:14
@jrbourbeau jrbourbeau mentioned this pull request Feb 2, 2022
Merged
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
@mroeschke @yehoshuadimarsky
DEPR: Index.is_monotonic for Index.is_monotonic_increasing (pandas-de…
b112fa5 
…v#45422)
@lukemanley lukemanley mentioned this pull request Nov 2, 2022
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbrockmendel jbrockmendel jbrockmendel left review comments

Assignees
No one assigned
Labels
Deprecate Functionality to remove in pandas
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.

PeriodIndex.is_monotonic only for monotonic increasing
3 participants
@mroeschke @jbrockmendel @jreback