Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TST,WARN: read_csv raises warning at wrong stacklevel, but _assert_raised_with_correct_stacklevel doesn't fail #47385

Closed
3 tasks done
MarcoGorelli opened this issue Jun 16, 2022 · 2 comments · Fixed by #47387
Closed
3 tasks done

TST,WARN: read_csv raises warning at wrong stacklevel, but _assert_raised_with_correct_stacklevel doesn't fail #47385

MarcoGorelli opened this issue Jun 16, 2022 · 2 comments · Fixed by #47387
Labels
Warnings Warnings that appear or should be added to pandas
Milestone
1.4.4

Comments

@MarcoGorelli
Copy link
Member

MarcoGorelli commented Jun 16, 2022 •
edited
Loading

Pandas version checks

  • I have checked that this issue has not already been reported.

  • I have confirmed this bug exists on the latest version of pandas.

  • I have confirmed this bug exists on the main branch of pandas.

Reproducible Example

Make a file t.py with

import io
import pandas as pd

pd.read_csv(io.StringIO('a'), ' ')

Issue Description

Running this on main gives

$ python t.py 
sys:1: FutureWarning: In a future version of pandas all arguments of read_csv except for the argument 'filepath_or_buffer' will be keyword-only.

Expected Behavior

I would have expected

$ python t.py 
t.py:4: FutureWarning: In a future version of pandas all arguments of read_csv except for the argument 'filepath_or_buffer' will be keyword-only.

cc @twoertwein in case you know what this might be due to

I noticed this in #47035 - find_stacklevel seems to be working correctly, I think it's the test which is wrong. Currently the test passes, although it should fail.

Installed Versions

INSTALLED VERSIONS

commit : f491c65
python : 3.9.2.final.0
python-bits : 64
OS : Linux
OS-release : 5.10.106-15290-g6e9d70c8a9b4
Version : #1 SMP PREEMPT Wed May 11 19:17:10 PDT 2022
machine : aarch64
processor :
byteorder : little
LC_ALL : None
LANG : en_US.UTF-8
LOCALE : en_US.UTF-8

pandas : 1.5.0.dev0+959.gf491c651bf
numpy : 1.22.4
pytz : 2022.1
dateutil : 2.8.2
setuptools : 62.1.0
pip : 22.0.4
Cython : 0.29.30
pytest : 7.1.2
hypothesis : 6.47.1
sphinx : None
blosc : None
feather : None
xlsxwriter : None
lxml.etree : None
html5lib : None
pymysql : None
psycopg2 : None
jinja2 : None
IPython : None
pandas_datareader: None
bs4 : None
bottleneck : None
brotli : None
fastparquet : None
fsspec : None
gcsfs : None
matplotlib : None
numba : None
numexpr : 2.8.1
odfpy : None
openpyxl : None
pandas_gbq : None
pyarrow : None
pyreadstat : None
pyxlsb : None
s3fs : None
scipy : None
snappy : None
sqlalchemy : None
tables : 3.7.0
tabulate : None
xarray : None
xlrd : None
xlwt : None
zstandard : None
@MarcoGorelli MarcoGorelli added the Warnings Warnings that appear or should be added to pandas label Jun 16, 2022
@MarcoGorelli MarcoGorelli mentioned this issue Jun 16, 2022
Merged
4 tasks
@MarcoGorelli
Copy link
Member Author

OK, the issue is that what's getting called is Parser.read_csv, which indeed is in conftest.py

@MarcoGorelli
Copy link
Member Author

Ah maybe it's enough to just use read_csv_check_warnings, I'll give that a go

@MarcoGorelli MarcoGorelli mentioned this issue Jun 16, 2022
Merged
5 tasks
@simonjayhawkins simonjayhawkins added this to the 1.4.4 milestone Jul 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Warnings Warnings that appear or should be added to pandas
Projects
None yet
Milestone
1.4.4
2 participants
@simonjayhawkins @MarcoGorelli