Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: GroupBy.min/max with unordered Categorical and no groups #51034

Merged
merged 5 commits into from
Jan 31, 2023
Merged

BUG: GroupBy.min/max with unordered Categorical and no groups #51034

merged 5 commits into from
Jan 31, 2023

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

Have figured out fixes for all the xfailed cases in test_groupby_empty, splitting them into specific bugfixes where appropriate.

@mroeschke mroeschke added Groupby Categorical Categorical Data Type labels Jan 30, 2023
@jbrockmendel jbrockmendel mentioned this pull request Jan 30, 2023
Merged
@mroeschke mroeschke added this to the 2.0 milestone Jan 31, 2023
@mroeschke mroeschke merged commit 39f72da into pandas-dev:main Jan 31, 2023
@mroeschke
Copy link
Member

Thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the bug-gb-cat branch January 31, 2023 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Categorical Categorical Data Type Groupby
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jbrockmendel @mroeschke