Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: ArrowExtensionArray logical ops raising KeyError #51688

Merged
merged 5 commits into from
Mar 6, 2023
Merged

BUG: ArrowExtensionArray logical ops raising KeyError #51688

merged 5 commits into from
Mar 6, 2023

Conversation

lukemanley
Copy link
Member

fixes the following:

import pandas as pd

ser = pd.Series([True, False, True], dtype="boolean[pyarrow]")

ser & True  # KeyError: 'and_'
ser | True  # KeyError: 'or_'

ser & ser   # KeyError: 'and_'
ser | ser   # KeyError: 'or_'

@lukemanley lukemanley added Bug Arrow pyarrow functionality labels Feb 28, 2023
@lukemanley lukemanley changed the title BUG: ArrowExtensionArray logical ops raising BUG: ArrowExtensionArray logical ops raising KeyError Feb 28, 2023
@lukemanley lukemanley mentioned this pull request Feb 28, 2023
Merged
4 tasks
@phofl
Copy link
Member

phofl commented Feb 28, 2023

cc @mroeschke

mroeschke
mroeschke approved these changes Mar 6, 2023
View reviewed changes
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Wouldn't be opposed to backporting to 2.0. WDYT @phofl?

@phofl
Copy link
Member

phofl commented Mar 6, 2023

Sounds good to me

@phofl phofl added this to the 2.0 milestone Mar 6, 2023
@phofl
Copy link
Member

phofl commented Mar 6, 2023

@lukemanley could you move the whatsnew?

@lukemanley
Copy link
Member Author

@lukemanley could you move the whatsnew?

moved to 2.0, thanks

@phofl phofl merged commit 178e504 into pandas-dev:main Mar 6, 2023
@phofl
Copy link
Member

phofl commented Mar 6, 2023

thx @lukemanley

@meeseeksmachine meeseeksmachine mentioned this pull request Mar 6, 2023
Merged
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Mar 6, 2023
@lukemanley @meeseeksmachine
Backport PR pandas-dev#51688: BUG: ArrowExtensionArray logical ops ra…
026833c 
…ising KeyError
phofl pushed a commit that referenced this pull request Mar 7, 2023
@meeseeksmachine @lukemanley
Backport PR #51688 on branch 2.0.x (BUG: ArrowExtensionArray logical …
6d5804b 
…ops raising KeyError) (#51810)

Backport PR #51688: BUG: ArrowExtensionArray logical ops raising KeyError

Co-authored-by: Luke Manley <lukemanley@gmail.com>
@lukemanley lukemanley deleted the arrow-logical-ops branch March 17, 2023 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

@phofl phofl phofl approved these changes

Assignees
No one assigned
Labels
Arrow pyarrow functionality Bug
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@lukemanley @phofl @mroeschke