Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PERF: Improve performance of MultiIndex._verify_integrity #51873

Merged
merged 3 commits into from
Mar 14, 2023
Merged

PERF: Improve performance of MultiIndex._verify_integrity #51873

merged 3 commits into from
Mar 14, 2023

Conversation

phofl
Copy link
Member

@phofl phofl commented Mar 9, 2023

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

recomputing the codes can be expensive, also avoids an is_unique check that is not cheap if not cached.

@phofl phofl added Performance Memory or execution speed performance MultiIndex labels Mar 9, 2023
topper-123
topper-123 reviewed Mar 12, 2023
View reviewed changes
Copy link
Contributor

@topper-123 topper-123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. A single comment.

@mroeschke mroeschke added this to the 2.1 milestone Mar 14, 2023
@mroeschke mroeschke merged commit 73dfc30 into pandas-dev:main Mar 14, 2023
@mroeschke
Copy link
Member

Thanks @phofl

@phofl phofl deleted the perf_verify_integrity branch March 14, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@topper-123 topper-123 topper-123 left review comments

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
MultiIndex Performance Memory or execution speed performance
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.
3 participants
@phofl @mroeschke @topper-123