Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TST: move Series.map tests to tests/series/methods/test_map.py #52384

Merged
merged 3 commits into from
Apr 4, 2023
Merged

TST: move Series.map tests to tests/series/methods/test_map.py #52384

merged 3 commits into from
Apr 4, 2023

Conversation

topper-123
Copy link
Contributor

@topper-123 topper-123 commented Apr 3, 2023 •
edited
Loading

Currently the tests for Series.map are mixed together with the tests for Series.apply. Keeping them separate makes it easier to find tests for one method and I've moved the map ones to tests/series/methods/test_map.py.

Also fixed a bug that I found in this proces:

>>> import pandas as pd
>>> ser = pd.Series([], dtype=int)
>>> ser.map(lambda: x + 1).dtype
object  # main
int64  # this PR

@topper-123 topper-123 mentioned this pull request Apr 4, 2023
Merged
@mroeschke mroeschke added Testing pandas testing functions or related to the test suite Apply Apply, Aggregate, Transform, Map labels Apr 4, 2023
@mroeschke mroeschke added this to the 2.1 milestone Apr 4, 2023
@mroeschke mroeschke merged commit 254720a into pandas-dev:main Apr 4, 2023
@mroeschke
Copy link
Member

Thanks @topper-123

@topper-123 topper-123 deleted the move_series_map_tests branch April 6, 2023 16:44
topper-123 added a commit to topper-123/pandas that referenced this pull request Apr 6, 2023
@topper-123
TST: move Series.map tests to tests/series/methods/test_map.py (panda…
e3bac83 
…s-dev#52384)

* TST: move Series.map tests to tests/series/methods/test_map.py

* add gh number

* fix pre-commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Apply Apply, Aggregate, Transform, Map Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.
2 participants
@topper-123 @mroeschke