Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: bool_only in any/all still defaults to None #53258

Closed
phofl opened this issue May 16, 2023 · 3 comments · Fixed by #53283
Closed

API: bool_only in any/all still defaults to None #53258

phofl opened this issue May 16, 2023 · 3 comments · Fixed by #53283
Assignees
@rhshadrach
Labels
API - Consistency Internal Consistency of API/Behavior Nuisance Columns Identifying/Dropping nuisance columns in reductions, groupby.add, DataFrame.apply Reduction Operations sum, mean, min, max, etc.

Comments

@phofl
Copy link
Member

phofl commented May 16, 2023

Shouldn't we change this to be consistent with numeric_only?

cc @rhshadrach was this deliberately not changed before 2.0?
@phofl phofl added API - Consistency Internal Consistency of API/Behavior Reduction Operations sum, mean, min, max, etc. labels May 16, 2023
@phofl phofl changed the title ENH: bool_only in any/all still defaults to None API: bool_only in any/all still defaults to None May 16, 2023
@rhshadrach
Copy link
Member

Yep - this was missed when grepping for numeric_only. Thanks.

@rhshadrach rhshadrach self-assigned this May 16, 2023
@rhshadrach rhshadrach added the Nuisance Columns Identifying/Dropping nuisance columns in reductions, groupby.add, DataFrame.apply label May 16, 2023
@phofl phofl added the Deprecate Functionality to remove in pandas label May 16, 2023
@phofl
Copy link
Member Author

phofl commented May 16, 2023

lets deprecate then and change in 3.0

@rhshadrach
Copy link
Member

I believe None behaves the same as False, so there isn't any difference from a user perspective. I think we can target this for 2.1.

@rhshadrach rhshadrach mentioned this issue May 17, 2023
Merged
5 tasks
@rhshadrach rhshadrach removed the Deprecate Functionality to remove in pandas label May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rhshadrach rhshadrach

Labels
API - Consistency Internal Consistency of API/Behavior Nuisance Columns Identifying/Dropping nuisance columns in reductions, groupby.add, DataFrame.apply Reduction Operations sum, mean, min, max, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BUG: Change default of bool_only to False rhshadrach/pandas
2 participants
@rhshadrach @phofl