Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: add ddof=1 argument to expanding/rolling_cov() #8279

Closed
seth-p opened this issue Sep 16, 2014 · 1 comment · Fixed by #8280
Closed

API: add ddof=1 argument to expanding/rolling_cov() #8279

seth-p opened this issue Sep 16, 2014 · 1 comment · Fixed by #8280
Labels
API Design Numeric Operations Arithmetic, Comparison, and Logical operations
Milestone
0.15.0

Comments

@seth-p
Copy link
Contributor

seth-p commented Sep 16, 2014

I think expanding/rolling_cov() should support a ddof argument, the way expanding/rolling_std/var() do (though the latter is not documented; see #8064). So long as ddof defaults to 1, it will be backwards compatible, so I don't see any downsides. This is very easy/straightforward.
@seth-p seth-p mentioned this issue Sep 16, 2014
Merged
@seth-p
Copy link
Contributor Author

seth-p commented Sep 16, 2014

If nothing else, having expanding/rolling_cov() support a ddof argument helps with more thorough testing in test_expanding/rolling_consistency().

@jreback jreback added API Design Numeric Operations Arithmetic, Comparison, and Logical operations labels Sep 16, 2014
@jreback jreback added this to the 0.15.0 milestone Sep 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API Design Numeric Operations Arithmetic, Comparison, and Logical operations
Projects
None yet
Milestone
0.15.0
Development

Successfully merging a pull request may close this issue.

API: add ddof to expanding/rolling_cov() seth-p/pandas
2 participants
@jreback @seth-p