-
-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pd.lib.infer_dtype infers bytes in Python3 #10032
Conversation
|
||
import pandas as pd | ||
from pandas.lib import isscalar, item_from_zerodim, max_len_string_array | ||
import pandas.util.testing as tm | ||
from pandas.compat import u | ||
|
||
PY2 = sys.version_info[0] == 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add this to pandas.compat
(or just import PY3
)
ping! |
? |
@jreback ok with this? |
oh whoops, need to add tests for strops |
and add to this line: https://github.com/pydata/pandas/blob/master/pandas/core/base.py#L522 (test if you can) squash as well. thxs |
ok, in progress |
hm, so to really be solid about this we'd have to test every single str operation against a bytes series e.g., |
Do we have to support |
no I don't think bytes are necessarily a big deal to support - in fact prob should raise on str type ops? |
ok, i'll test that we raise on |
ok, looks good. just add a release note and merge. ty. |
pd.lib.infer_dtype infers bytes in Python3
No description provided.