Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: make sure return dtypes for nan funcs are consistent #10251

Merged
merged 1 commit into from
Jun 5, 2015
Merged

ENH: make sure return dtypes for nan funcs are consistent #10251

merged 1 commit into from
Jun 5, 2015

Conversation

mortada
Copy link
Contributor

@mortada mortada commented Jun 2, 2015

this is a follow-up to #10172

In addition to mean(), this PR also makes sure the returned dtype is consistent for std(), var(), skew(), and kurt()

@jreback jreback added Bug Dtype Conversions Unexpected or buggy dtype conversions Numeric Operations Arithmetic, Comparison, and Logical operations labels Jun 2, 2015
@jreback jreback added this to the 0.16.2 milestone Jun 2, 2015
@mortada mortada force-pushed the nan_func_dtype branch 3 times, most recently from f4ce38e to 24463c6 Compare June 4, 2015 20:34
@mortada
Copy link
Contributor Author

mortada commented Jun 4, 2015

also included tests for min() and max()

jreback
jreback reviewed Jun 4, 2015
View reviewed changes
pandas/tests/test_nanops.py
# check returned dtype
for dtype in [np.int16, np.int32, np.int64, np.float16, np.float32, np.float64]:
def test_returned_dtype(self):
from pandas import Series
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

put at the top of the file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea, will update

jreback added a commit that referenced this pull request Jun 5, 2015
@jreback
Merge pull request #10251 from mortada/nan_func_dtype
bfbeb29 
ENH: make sure return dtypes for nan funcs are consistent
@jreback jreback merged commit bfbeb29 into pandas-dev:master Jun 5, 2015
@jreback
Copy link
Contributor

jreback commented Jun 5, 2015

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Dtype Conversions Unexpected or buggy dtype conversions Numeric Operations Arithmetic, Comparison, and Logical operations
Projects
None yet
Milestone
0.16.2
Development

Successfully merging this pull request may close these issues.
2 participants
@mortada @jreback