Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pd.merge_asof() matches out of tolerance when allow_exact_matches=False #13695

Closed
chrisaycock opened this issue Jul 18, 2016 · 1 comment
Closed

pd.merge_asof() matches out of tolerance when allow_exact_matches=False #13695

chrisaycock opened this issue Jul 18, 2016 · 1 comment
Labels
Bug Reshaping Concat, Merge/Join, Stack/Unstack, Explode
Milestone
0.19.0

Comments

@chrisaycock
Copy link
Contributor

Using these DataFrames for this example:

df1 = pd.DataFrame({'time':pd.to_datetime(['2016-07-15 13:30:00.030']), 'username':['bob']})
df2 = pd.DataFrame({'time':pd.to_datetime(['2016-07-15 13:30:00.000', '2016-07-15 13:30:00.030']), 'version':[1, 2]})

I can perform the pd.merge_asof() as expected:

In [153]: df1
Out[153]:
                     time username
0 2016-07-15 13:30:00.030      bob

In [154]: df2
Out[154]:
                     time  version
0 2016-07-15 13:30:00.000        1
1 2016-07-15 13:30:00.030        2

In [155]: pd.merge_asof(df1, df2, on='time')
Out[155]:
                     time username  version
0 2016-07-15 13:30:00.030      bob        2

If I disable the exact matches, then I get the prior entry as expected:

In [156]: pd.merge_asof(df1, df2, on='time', allow_exact_matches=False)
Out[156]:
                     time username  version
0 2016-07-15 13:30:00.030      bob        1

But the tolerance isn't respected when I disable the exact matches!

In [157]: pd.merge_asof(df1, df2, on='time', allow_exact_matches=False, tolerance=pd.Timedelta('10ms'))
Out[157]:
                     time username  version
0 2016-07-15 13:30:00.030      bob        1

I expect to get a null here.

This is pandas version 0.18.0+408.gd8f3d73.
@jreback
Copy link
Contributor

jreback commented Jul 18, 2016

hmm, that does look buggy

@jreback jreback added Bug Reshaping Concat, Merge/Join, Stack/Unstack, Explode Difficulty Novice labels Jul 18, 2016
@jreback jreback added this to the 0.19.0 milestone Jul 18, 2016
jreback added a commit to jreback/pandas that referenced this issue Jul 18, 2016
@jreback
BUG: merge_asof not handling allow_exact_matches and tolerance on fir…
c46dcfa 
…st entry

closes pandas-dev#13695
@jreback jreback mentioned this issue Jul 18, 2016
Closed
@chrisaycock chrisaycock mentioned this issue Jul 19, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Reshaping Concat, Merge/Join, Stack/Unstack, Explode
Projects
None yet
Milestone
0.19.0
Development

Successfully merging a pull request may close this issue.

BUG: merge_asof not handling allow_exact_matches and tolerance on first entry jreback/pandas
2 participants
@chrisaycock @jreback