Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: wrong exception raised by Week+Day #28530

Merged
merged 9 commits into from
Sep 19, 2019
Merged

BUG: wrong exception raised by Week+Day #28530

merged 9 commits into from
Sep 19, 2019

Conversation

jbrockmendel
Copy link
Member

With that fixed, we can clean up an Exception in tseries.frequencies.

@WillAyd
Copy link
Member

WillAyd commented Sep 19, 2019

Makes sense to me. Can you add a whatsnew for 1.0.0?

@WillAyd WillAyd added the Error Reporting Incorrect or improved errors from pandas label Sep 19, 2019
@WillAyd WillAyd added this to the 1.0 milestone Sep 19, 2019
TomAugspurger
TomAugspurger approved these changes Sep 19, 2019
View reviewed changes
Copy link
Contributor

@TomAugspurger TomAugspurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that this will continue to work with thing like pendulum.DateTime, which is a subclass of datetime.datetime.

@jbrockmendel
Copy link
Member Author

Verified that this will continue to work with thing like pendulum.DateTime, which is a subclass of datetime.datetime.

Is this something we need to test more generally?

@TomAugspurger
Copy link
Contributor

Probably not. Just had reports from them in the past.

@TomAugspurger TomAugspurger merged commit 4729766 into pandas-dev:master Sep 19, 2019
@jbrockmendel jbrockmendel deleted the faster18 branch September 19, 2019 21:10
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@jbrockmendel @proost
BUG: wrong exception raised by Week+Day (pandas-dev#28530)
3542598 
* BUG: Week+Day raising wrong exception

* whatsnew
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@jbrockmendel @proost
BUG: wrong exception raised by Week+Day (pandas-dev#28530)
e053d77 
* BUG: Week+Day raising wrong exception

* whatsnew
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomAugspurger TomAugspurger TomAugspurger approved these changes

Assignees
No one assigned
Labels
Error Reporting Incorrect or improved errors from pandas
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockmendel @WillAyd @TomAugspurger