New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Timedelta == ndarray[td64] #33441

Merged

jreback merged 2 commits into pandas-dev:master from jbrockmendel:ref-td-cmp

Apr 10, 2020

Member

jbrockmendel commented Apr 9, 2020

Between the two of these, we should be able to get rid of this kludge: https://github.com/pandas-dev/pandas/blob/master/pandas/core/internals/managers.py#L629

IIRC there were some test_coercion xfails related to that kludge, will be worth revisiting.

jbrockmendel added 2 commits

April 9, 2020 12:47


          BUG: Timedelta == ndarray[td64]

df4e465


          GH ref

jbrockmendel added the Bug label

jbrockmendel mentioned this pull request

REF: remove replace_list kludge #33445

Merged

jreback requested changes

View reviewed changes

Contributor

jreback left a comment

do we have tests for NaT (object and inside the ndarray and 0-dim?

Member Author

jbrockmendel commented Apr 10, 2020

do we have tests for NaT (object and inside the ndarray and 0-dim?

no, i have the 0-d case in my notes for a follow-up

jorisvandenbossche approved these changes

View reviewed changes

jreback added this to the 1.1 milestone

jreback added the Timedelta label

jreback approved these changes

View reviewed changes

jreback merged commit fe42954 into pandas-dev:master

Contributor

jreback commented Apr 10, 2020

thanks

jbrockmendel deleted the ref-td-cmp branch

April 10, 2020 18:06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels